Skip to content

Conversation

@mgovers
Copy link
Member

@mgovers mgovers commented Jun 10, 2025

@mgovers mgovers self-assigned this Jun 10, 2025
@mgovers mgovers added dependencies Pull requests that update a dependency file improvement Existing functionality, but better, faster, stronger labels Jun 10, 2025
@mgovers mgovers changed the title fix ci: github actions requires ci-passed + bump pre-commit + fix mypy Fix ci: github actions requires ci-passed + bump pre-commit + fix mypy Jun 10, 2025
@mgovers mgovers added bug Something isn't working and removed improvement Existing functionality, but better, faster, stronger labels Jun 10, 2025
@mgovers
Copy link
Member Author

mgovers commented Jun 10, 2025

Quality Gate Failed Quality Gate failed

Failed conditions 50.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

it only concerns fall-back logic. not needed to test

@mgovers mgovers enabled auto-merge June 10, 2025 12:23
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
50.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@mgovers mgovers requested a review from nitbharambe June 10, 2025 12:28
@mgovers mgovers added this pull request to the merge queue Jun 10, 2025
@nitbharambe
Copy link
Member

nitbharambe commented Jun 10, 2025

Branch name does not match changes. Adding comment for future reference.

Merged via the queue into main with commit 21b8e75 Jun 10, 2025
30 of 31 checks passed
@mgovers mgovers deleted the feature/update-examples branch June 10, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants